fix: get account with base64+zstd - #737
Conversation
Greptile SummaryEnables zstd support for Solana account decoder client types and adds coverage for Base64Zstd account responses.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The dependency feature is paired with a test that exercises the production getAccountInfo encoding path and validates a complete Base64Zstd round trip. Important Files Changed
Reviews (1): Last reviewed commit: "fix: get account with base64+zstd" | Re-trigger Greptile |
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
Thanks for the PR, @Arrowana! Was this an issue you had? It's great to have the test, but it passes without the associated dep change, so I want to be sure we're fixing any underlying issue you had
| solana-account-decoder = { version = "4.0", default-features = false } | ||
| solana-account-decoder-client-types = { version = "4.0", default-features = false } | ||
| solana-account-decoder-client-types = { version = "4.0", default-features = false, features = [ | ||
| "zstd", |
There was a problem hiding this comment.
I removed this feature and the test above still passed. Are we sure it's needed?
There was a problem hiding this comment.
Both solana-account-decoder and solana-rpc-client already enable solana-account-decoder-client-types/zstd
so yes that's indeed incorrect, i think the symptoms are similar to #738 but the root cause was misdiagnosed wildly
2 participants
This should work out of the box, that's also the rust
solana-rpc-clientdefault